Skip to content

Make cplchm false the default for global coupled configurations#3163

Open
DeniseWorthen wants to merge 12 commits intoufs-community:developfrom
DeniseWorthen:feature/cplchmfalse
Open

Make cplchm false the default for global coupled configurations#3163
DeniseWorthen wants to merge 12 commits intoufs-community:developfrom
DeniseWorthen:feature/cplchmfalse

Conversation

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen commented Mar 25, 2026

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers. NA
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

Commit Message:

* UFSWM - set cplchm to false for global coupled and update tests
* UFSWM - reduce fhmax for control_wam test
* UFSWM - add ocn stoch restart file for comparison in datm_cdeps_stochy_gefs test

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Documentation:

  • Documentation update NOT required.
    • Explanation: standard RT update

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines. Baseline changes are limited to non-B4B ATM tracer restart files and physics history files (atmfXXX.nc) due to the removal of the aerosol tracer fields. All other files are B4B. The impacted tests are
cpld_2threads_p8_intel
cpld_control_c192_p8_intel
cpld_control_ciceC_p8_intel
cpld_control_p8.v2.sfc_intel
cpld_control_p8_intel.log
cpld_decomp_p8_intel
cpld_mpi_p8_intel

The following tests fail the current baselines do not contain a comparison file

rt_control_wam_intel.log:5: Comparing sfcf06.nc ............MISSING file
rt_control_wam_intel.log:6: Comparing atmf06.nc ............MISSING file
rt_datm_cdeps_stochy_gefs_intel.log:6: Comparing RESTART/20111002.000000.ocn_stoch.res.nc ............MISSING baseline

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@github-project-automation github-project-automation bot moved this to Evaluating in PRs to Process Mar 25, 2026
@DeniseWorthen DeniseWorthen self-assigned this Mar 25, 2026
@DeniseWorthen DeniseWorthen changed the title make cplchm false the default Make cplchm false the default for global coupled configurations Mar 25, 2026
@DeniseWorthen DeniseWorthen marked this pull request as ready for review March 26, 2026 11:36
@gspetro-NOAA gspetro-NOAA added the Baseline Updates Current baselines will be updated. label Mar 30, 2026
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Review in PRs to Process Mar 30, 2026
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@DeniseWorthen I know you were planning to do some work to resolve the HAFS hardcoding and possibly integrate it into this PR. If that is still the plan, would you be willing to incorporate in the minor changes from Jiande's PR #3177 before you test? I am having Jiande run the RT test that his PR modifies, and then we're hoping to combine it for full testing w/another PR because it seems like a massive waste of resources to run the entire suite on that PR for such minor changes. Dan suggested this PR might be a good candidate, but we can see about combining w/another PR if that won't work for you.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

@gspetro-NOAA As it turns out, the issue w/ the HAFS Intelllvm debug test is more complicated. It didn't reproduce itself, so we turned it off. I think combining #3177 with this would be fine. I actually needed to re-run this one, since I noticed that I still had gocart files in the comparison lists.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

@gspetro-NOAA I can also reduce FHMAX for the control_wam test. That one is driving me nuts timing out.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@gspetro-NOAA I can also reduce FHMAX for the control_wam test. That one is driving me nuts timing out.

That would be fantastic, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated.

Projects

Status: Review

3 participants